-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust PaymentPlan model to contain informations coming from TP and HS #4372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add tp list rest
MarekBiczysko
requested changes
Nov 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4372 +/- ##
===========================================
- Coverage 85.03% 85.02% -0.02%
===========================================
Files 515 516 +1
Lines 36333 36326 -7
===========================================
- Hits 30897 30887 -10
- Misses 5436 5439 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pavlo-mk
added
frontend
Changes in FE code
and removed
work in progress
Change doesn't need to be reviewed
labels
Jan 9, 2025
MarekBiczysko
approved these changes
Jan 10, 2025
pkujawa
reviewed
Jan 13, 2025
pkujawa
approved these changes
Jan 13, 2025
pavlo-mk
added a commit
that referenced
this pull request
Jan 15, 2025
* uv * fixes / mypy dont pass * fix compose paths * fix e2e * 228219_fincacial_service_provider_admin_fix * fix flaky test failing due to beginning of new year * fix another flaky test * fix also last_Registration_date * 217655_dedup_statistics_rdi_population_preview (#4545) * Adjust PaymentPlan model to contain informations coming from TP and HS (#4372) * init * add tp list rest * init changes * add TP_MIGRATION_MAPPING * modify create target population add collector group * style 🎯 * add collector filters blocks * upd few more fields and properties * move full_rebuild & refactoring * add collector rule groups * add CheckConstraint & migrations * update validation & migrations * upd tests * upd migrations * fe cleanup & add more ut 🌟 * coverage 💯 * init script * upd * script optimization * refactor: create/upd mutation * add updated_tc_rules * refactor mutations * refactor mutations * upd migrations * more fixes * migrations // fix initdemo * migration * add more statuses transitions * fixes * fixes // upd unit tests * more refactoring and upd unit tests * unit tests // fixes * conflicts & remove unused TPnode * migrations conflict * migration * add TODOs & skip * add more tests // fixes * remove unused code * fixes // add more tests * upd snapshot * more tests * more tests * add more 💯 🌟 * upd migration script * change mutations part 1 * add more test & refactoring migration script * add test_migrate_tp_into_pp * more adjustments * upd tests & fix .delete() * remove imports * upd test * delete, copy * accountability * add filters isTargetPopulation & isPaymentPlan * more changes * generate schema * add migrate_message_and_survey * fix update targeting_criteria * upd filter * migration script upd * more changes * more * add more unit tests ⭐ * fix migration script & upd unit tests 🌟 * next part * more * more changes * upd filters * add total_households_count_with_valid_phone_no * upd filter * fix * another part * add noStatus filter * statusNot * add GraphQLError when no ba header for allPrograms query * frontend compiles * fixes * fix payments lists TP * fix pp list * lint * fix snapshots * minor fixes * fix buttons and status * fix pp queries * fix generated * fix schema * fix e2e fixtures * upd statuses * fixes 🌟 * unit tests ⭐ * unit tests & coverage 🌟 * fix e2e * fix e2e * fix labels + lock unlock * id undefined * fix mutation * bring back verify manual * bug fixes * targeting hh fix * upd fe test * fix fe fixtures * fix more e2e * again fix more e2e * fix e2e * schema * upd filtering * test with e2e * test with test_edit_targeting * add xfail * small fixes * update snapshots * fixes * upd test * add open pp mutation * fix upd currency ⭐ * review * migration * ba fixtures * fe schema upd * remove isPaymentPlanApplicable and Draft status * clean up * upd filters * fix status * change steficon mutation * steficon pp * upd mutations * upd schema * fixes for SetSteficonRuleOnPaymentPlanPaymentListMutation * fe lint * remove none option in vulnerability component * fix ut * fe fixes * more fixes * upd query 🌟 * review * one more fix * revert filtering back --------- Co-authored-by: Maciej Szewczyk <[email protected]> Co-authored-by: Maciej Szewczyk <[email protected]> Co-authored-by: marekbiczysko <[email protected]> * fixing path * cert download develop * exclude hope on dev install * fix docker file one more time python path for dev image * New API endpoints aurora (#4548) * WIP: add OrganizationListView * WIP: upd api & add simple unit tests * ut * add cache & upd unit tests * remove pdm.lock * fixes for selenium test localy * DEV update migration script TP>PP (#4553) * upd migrations script * fix 🌟 * upd comment --------- Co-authored-by: Jan Romaniak <[email protected]> Co-authored-by: marekbiczysko <[email protected]> Co-authored-by: Domenico <[email protected]> Co-authored-by: Paulina Kujawa <[email protected]> Co-authored-by: Paulina Kujawa <[email protected]> Co-authored-by: Marek Biczysko <[email protected]> Co-authored-by: Maciej Szewczyk <[email protected]> Co-authored-by: Maciej Szewczyk <[email protected]> Co-authored-by: Jan Romaniak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use one model for TP and PP
PaymentPlan
AB#215785: Adjust PaymentPlan model to contain informations coming from TP and HS
AB#215790: Adjust Payment Module to filter out the Payment Plan which are draft (old Target Population)
one time script
migrate_tp_into_pp
TP rule now using Payment Plan:
result = rule.execute( { "household": payment.household, "payment_plan": payment_plan, } )